added default-repo to getting started #1672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balopat
requested review from
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
balopat
added
the
docs-modifications
|
Please visit http://35.235.69.96:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
Codecov Report
@@ Coverage Diff @@
## master #1672 +/- ##
==========================================
+ Coverage 47.41% 48.34% +0.93%
==========================================
Files 122 122
Lines 5448 5558 +110
==========================================
+ Hits 2583 2687 +104
- Misses 2604 2607 +3
- Partials 261 264 +3
Continue to review full report at Codecov.
|
nkubala
reviewed
Feb 19, 2019
| @@ -144,8 +144,9 @@ https://storage.googleapis.com/skaffold/builds/latest/skaffold-windows-amd64.exe | |||
|
|
|||
| ## `skaffold dev`: Build and deploy your app every time your code changes | |||
|
|
|||
| Run command `skaffold dev` to build and deploy your app continuously. You should | |||
| see some outputs similar to the following entries: | |||
| Run command `skaffold dev --default-repo <myrepo>` to build and deploy your app continuously. | |||
There was a problem hiding this comment.
can we remove the word command here? sentence is a bit awkward with it.
| Run command `skaffold dev` to build and deploy your app continuously. You should | ||
| see some outputs similar to the following entries: | ||
| Run command `skaffold dev --default-repo <myrepo>` to build and deploy your app continuously. | ||
| The `--default-repo` functionality enables to push images to your own repository instead of the default `gcr.io/k8s-skaffold` repo. |
There was a problem hiding this comment.
s/enables to push/enables pushing
| @@ -5,3 +5,10 @@ weight: 90 | |||
| --- | |||
|
|
|||
| See the [Github Examples page](https://github.com/GoogleContainerTools/skaffold/tree/master/examples) for examples. | |||
|
|
|||
| To run the examples, you either have to manually replace the image repositories in the examples from gcr.io/k8s-skaffold to yours or you can point skaffold to your default image repository in one of the four ways: | |||
There was a problem hiding this comment.
a little nitpicky: can this be structured something like:
To run the examples in the repo, you have two options:
1) manually replace the image repositories in the example skaffold.yamls from gcr.io/k8s-skaffold to your own person repository
2) point skaffold to your default image repository in one of the four ways:
....
this just makes it a bit more clear to the user why it's being done this way, and why the default-repo stuff even exists in the first place.
balopat
added
the
docs-modifications
|
Please visit http://35.235.74.87:1313 to view changes to the docs. |
container-tools-bot
removed
the
docs-modifications
dgageot
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1669.