Check for new skaffold version when skaffold.yaml parsing fails #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusweig
requested review from
balopat,
dgageot,
nkubala,
priyawadhwa and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1587 +/- ##
==========================================
+ Coverage 46.51% 46.92% +0.41%
==========================================
Files 118 119 +1
Lines 5044 5072 +28
==========================================
+ Hits 2346 2380 +34
+ Misses 2464 2458 -6
Partials 234 234
Continue to review full report at Codecov.
|
nkubala
reviewed
Feb 4, 2019
Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
force-pushed
the
version-check
branch
from
da9e7d8
to
cfe18e8
Compare
Signed-off-by: Cornelius Weig <[email protected]>
corneliusweig
force-pushed
the
version-check
branch
from
cfe18e8
to
7906779
Compare
nkubala
approved these changes
Feb 4, 2019
balopat
suggested changes
Feb 5, 2019
Signed-off-by: Cornelius Weig <[email protected]>
balopat
approved these changes
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-uses the already existing asynchronous version check. Now, if parsing fails, the check is repeated synchronously and an appropriate warning is shown.
Fixes #1570