Better profiles #1541
Merged
Better profiles #1541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgageot
force-pushed
the
better-profiles
branch
from
a7320d7
to
ee13075
Compare
Codecov Report
@@ Coverage Diff @@
## master #1541 +/- ##
=========================================
+ Coverage 46.18% 46.58% +0.4%
=========================================
Files 118 118
Lines 4961 5019 +58
=========================================
+ Hits 2291 2338 +47
- Misses 2439 2447 +8
- Partials 231 234 +3
Continue to review full report at Codecov.
|
dgageot
force-pushed
the
better-profiles
branch
3 times, most recently
from
d8c952c
to
0d32461
Compare
balopat
reviewed
Jan 30, 2019
balopat
reviewed
Jan 30, 2019
| # kubeContext: ctx1 | ||
| # Also auto-activate `skaffold dev` is run | ||
| # - command: run | ||
| # Also auto-activate is the kubeContext is NOT `ctx2` |
There was a problem hiding this comment.
Suggested change
| # Also auto-activate is the kubeContext is NOT `ctx2` | |
| # Also auto-activate if the kubeContext is NOT `ctx2` |
balopat
reviewed
Jan 30, 2019
balopat
reviewed
Jan 30, 2019
balopat
reviewed
Jan 30, 2019
pkg/skaffold/schema/profile_test.go
Outdated
| expected []string | ||
| shouldErr bool | ||
| }{ | ||
| { |
There was a problem hiding this comment.
There are no tests covering the case where the Activation array has multiple activations. It is unclear whether the relationship between multiple activations should be OR or AND - it looks like from the implementation that it's a logical OR - we should also mention this in the annotated-skaffold.yaml
balopat
suggested changes
Jan 30, 2019
There was a problem hiding this comment.
Thank you for this!
This is closing #1536?
I marked some nits.
plus some items for discussion:
- json patch:
- why json? + now we'll start to have file sprawl instead of a single skaffold yaml describing the config
- it doesn't have an integration test - would be nice to see an example
|
@balopat Thanks for the review!
|
dgageot
force-pushed
the
better-profiles
branch
from
0d32461
to
50fdecd
Compare
dgageot
force-pushed
the
better-profiles
branch
from
50fdecd
to
50e1fe0
Compare
Fixes GoogleContainerTools#1536 Signed-off-by: David Gageot <[email protected]>
Fix GoogleContainerTools#1271 Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
better-profiles
branch
from
50e1fe0
to
cac573b
Compare
Signed-off-by: David Gageot <[email protected]>
dgageot
force-pushed
the
better-profiles
branch
from
cac573b
to
2522d70
Compare
balopat
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements two features related to Profiles: