Support Jib on Google Cloud Build #1478
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
+ Coverage 44.8% 44.84% +0.04%
==========================================
Files 112 115 +3
Lines 4638 4696 +58
==========================================
+ Hits 2078 2106 +28
- Misses 2350 2372 +22
- Partials 210 218 +8
Continue to review full report at Codecov.
|
|
Looks like the kokoro failure is not related. Or is it? |
| @@ -59,6 +59,8 @@ const ( | |||
| UpdateCheckEnvironmentVariable = "SKAFFOLD_UPDATE_CHECK" | |||
|
|
|||
| DefaultCloudBuildDockerImage = "gcr.io/cloud-builders/docker" | |||
| DefaultCloudBuildMavenImage = "gcr.io/cloud-builders/mvn" | |||
There was a problem hiding this comment.
WDYT about using the gcr.io/k8s-skaffold/skaffold image for every builder?
Then we wouldn't have to use multiple images
There was a problem hiding this comment.
Copy the context + skaffold.yaml, then invoke skaffold build and you get all the builders for free.
There was a problem hiding this comment.
I don't know about that. I have a few questions:
- Is skaffold pre-pulled on GCB?
- How would you build only one artifact with
skaffold build? - Isn't that a bit too inception-ish?
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
There was a problem hiding this comment.
This PR as is LGTM, I'm still not sure how I feel about your comment @r2d4 so I'll let you two figure that out. Up to you whether you want to merge this as is or wait to make that requested change. We could always change it later on too.
| cloudbuild "google.golang.org/api/cloudbuild/v1" | ||
| ) | ||
|
|
||
| // TODO(dgageot): check that `package` is bound to `jib:build` |
There was a problem hiding this comment.
is this still TODO or can it be removed?
There was a problem hiding this comment.
It is still a TODO that might or might not be important
Requires a new schema version (
v1beta3)