Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localDir context for Kaniko on Windows #1438

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Fix localDir context for Kaniko on Windows #1438

merged 1 commit into from
Jan 9, 2019

Conversation

cedrickring
Copy link
Contributor

So I'm just extracting the context immediately in the empty dir by passing it as Stdin to the kubectl exec command.

WDYT @priyawadhwa

@codecov-io
Copy link

codecov-io commented Jan 4, 2019

Codecov Report

Merging #1438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1438   +/-   ##
=======================================
  Coverage   44.53%   44.53%           
=======================================
  Files         112      112           
  Lines        4596     4596           
=======================================
  Hits         2047     2047           
  Misses       2342     2342           
  Partials      207      207

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 738e995...8200bc1. Read the comment docs.

@priyawadhwa priyawadhwa added area/build kokoro:run runs the kokoro jobs on a PR and removed area/build labels Jan 4, 2019
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Jan 4, 2019
Copy link
Contributor

@priyawadhwa priyawadhwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for contributing a fix for this! :)

@balopat balopat merged commit cd4aeef into GoogleContainerTools:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants