Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor docker api #1429

Merged
merged 1 commit into from
Dec 28, 2018
Merged

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Dec 27, 2018

  • Introduce a LocalDaemon type that wraps all the local Docker operations.
  • Move some of the docker related code to this new type

@codecov-io
Copy link

codecov-io commented Dec 27, 2018

Codecov Report

Merging #1429 into master will decrease coverage by 0.13%.
The diff coverage is 15.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1429      +/-   ##
==========================================
- Coverage    44.7%   44.56%   -0.14%     
==========================================
  Files         111      112       +1     
  Lines        4579     4593      +14     
==========================================
  Hits         2047     2047              
- Misses       2325     2339      +14     
  Partials      207      207
Impacted Files Coverage Δ
pkg/skaffold/docker/parse.go 75.11% <0%> (+7.19%) ⬆️
pkg/skaffold/build/local/types.go 0% <0%> (ø) ⬆️
pkg/skaffold/build/local/bazel.go 40% <0%> (+2.5%) ⬆️
pkg/skaffold/docker/remote.go 0% <0%> (ø)
pkg/skaffold/build/local/jib_gradle.go 21.87% <0%> (ø) ⬆️
pkg/skaffold/build/local/jib_maven.go 38.59% <0%> (ø) ⬆️
pkg/skaffold/docker/auth.go 36.36% <25%> (ø) ⬆️
pkg/skaffold/docker/image.go 57.14% <27.9%> (+0.89%) ⬆️
pkg/skaffold/docker/client.go 60.82% <28.57%> (-1.29%) ⬇️
pkg/skaffold/build/local/local.go 54.34% <33.33%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2043aaf...ac6bb3a. Read the comment docs.

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot merged commit 182b762 into GoogleContainerTools:master Dec 28, 2018
@dgageot dgageot deleted the refactor-docker-api branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants