Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors in release walking #1356

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Handle errors in release walking #1356

merged 1 commit into from
Dec 4, 2018

Conversation

tmc
Copy link
Contributor

@tmc tmc commented Dec 3, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 3, 2018 •
edited
Loading

Codecov Report

Merging #1356 into master will decrease coverage by 0.03%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1356      +/-   ##
==========================================
- Coverage   45.05%   45.01%   -0.04%     
==========================================
  Files         114      114              
  Lines        4910     4914       +4     
==========================================
  Hits         2212     2212              
- Misses       2473     2475       +2     
- Partials      225      227       +2
Impacted Files Coverage Δ
pkg/skaffold/deploy/helm.go 64.35% <20%> (-1.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4f429f...39028ed. Read the comment docs.

@priyawadhwa priyawadhwa added the kokoro:run runs the kokoro jobs on a PR label Dec 3, 2018
@kokoro-team kokoro-team removed the kokoro:run runs the kokoro jobs on a PR label Dec 3, 2018
@balopat balopat added the kokoro:run runs the kokoro jobs on a PR label Dec 3, 2018
balopat
balopat approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit eae1904 into GoogleContainerTools:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balopat balopat balopat approved these changes

@dgageot dgageot Awaiting requested review from dgageot

@nkubala nkubala Awaiting requested review from nkubala

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
kokoro:run runs the kokoro jobs on a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tmc @codecov-io @balopat @priyawadhwa @kokoro-team