Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to annotated-skaffold.yaml #1310

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Nov 22, 2018

Signed-off-by: David Gageot [email protected]

@codecov-io
Copy link

Codecov Report

Merging #1310 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1310   +/-   ##
=======================================
  Coverage   44.98%   44.98%           
=======================================
  Files         106      106           
  Lines        4737     4737           
=======================================
  Hits         2131     2131           
  Misses       2385     2385           
  Partials      221      221

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a52cc32...ebd9cee. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balopat balopat merged commit 06bed4b into GoogleContainerTools:master Nov 23, 2018
@dgageot dgageot deleted the add-missing-fields branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants