Add caching to kaniko builder #1287
Conversation
I updated the version of the kaniko image so that I could add caching. To use caching, the user has to specify 'cache' in their skaffold.yaml, with an optional field for 'repo', which is where cached layers will be stored.
priyawadhwa
requested review from
balopat,
dgageot,
nkubala and
r2d4
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1287 +/- ##
=========================================
- Coverage 44.24% 44.2% -0.04%
=========================================
Files 104 104
Lines 4629 4633 +4
=========================================
Hits 2048 2048
- Misses 2372 2376 +4
Partials 209 209
Continue to review full report at Codecov.
|
|
For sure, should be an easy change. |
| @@ -46,7 +46,7 @@ const ( | |||
|
|
|||
| DefaultKustomizationPath = "." | |||
|
|
|||
| DefaultKanikoImage = "gcr.io/kaniko-project/executor:v0.4.0@sha256:0bbaa4859eec9796d32ab45e6c1627562dbc7796e40450295b9604cd3f4197af" | |||
| DefaultKanikoImage = "gcr.io/kaniko-project/executor@sha256:434bbb1d998ba1bd8ebc04c90d93afa859fd5c7ff93326bca9f6e7da0d6277ff" | |||
There was a problem hiding this comment.
Can you leave the version here, in addition to the sha256? It makes it easier to find which version we are using.
There was a problem hiding this comment.
kaniko actually hasn't released a version with the new caching stuff yet -- I was going to come back to this and add the new version in once that happened.
There was a problem hiding this comment.
I'll open an issue for it!
I updated the version of the kaniko image so that I could add caching.
To use caching, the user has to specify 'cache' in their skaffold.yaml,
with an optional field for 'repo', which is where cached layers will be
stored.
Fixes #1275