Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default-repo config documentation #1194

Merged
merged 2 commits into from
Oct 23, 2018

Conversation

balopat
Copy link
Contributor

@balopat balopat commented Oct 23, 2018

Fixing the nits in #1057.

@balopat balopat changed the title Default repo nits default-repo config documentation Oct 23, 2018
@codecov-io
Copy link

codecov-io commented Oct 23, 2018

Codecov Report

Merging #1194 into master will decrease coverage by 0.02%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1194      +/-   ##
==========================================
- Coverage   41.47%   41.45%   -0.03%     
==========================================
  Files          95       95              
  Lines        4229     4229              
==========================================
- Hits         1754     1753       -1     
- Misses       2304     2305       +1     
  Partials      171      171
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/config/util.go 33.73% <ø> (-0.79%) ⬇️
pkg/skaffold/util/image.go 100% <ø> (ø) ⬆️
cmd/skaffold/app/cmd/config/list.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/helm.go 65.56% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c902ebe...d2f3e33. Read the comment docs.

@balopat balopat merged commit 3c27520 into GoogleContainerTools:master Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants