Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fully qualified jib path for maven goals #1129

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Remove fully qualified jib path for maven goals #1129

merged 1 commit into from
Oct 9, 2018

Conversation

loosebazooka
Copy link
Member

@briandealwis moved toward enforcing the plugin on the project.

@codecov-io
Copy link

Codecov Report

Merging #1129 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1129   +/-   ##
=======================================
  Coverage   44.09%   44.09%           
=======================================
  Files          84       84           
  Lines        3667     3667           
=======================================
  Hits         1617     1617           
  Misses       1895     1895           
  Partials      155      155
Impacted Files Coverage Δ
pkg/skaffold/build/local/jib_maven.go 35% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67b291...448f510. Read the comment docs.

@dgageot dgageot merged commit 792b215 into GoogleContainerTools:master Oct 9, 2018
@coollog coollog mentioned this pull request Oct 9, 2018
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants