Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Go 1.11 to Travis build matrix #1127

Closed
wants to merge 1 commit into from
Closed

Add Go 1.11 to Travis build matrix #1127

wants to merge 1 commit into from

Conversation

emirb
Copy link

@emirb emirb commented Oct 9, 2018

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot
Copy link

CLAs look good, thanks!

@nkubala
Copy link
Contributor

nkubala commented Oct 9, 2018

Looks like the version of golangci-lint we're using (1.9.2) is broken with Go 1.11. I opened a PR to upgrade the version, once that goes in do a rebase and Travis should pass.

@nkubala
Copy link
Contributor

nkubala commented Oct 16, 2018

sorry, the PR I opened last week didn't actually seem to fix it :( I got it to pass for 1.11 but not 1.10, and the version we're on passes for 1.10 but not 1.11....not sure what's going on there

@balopat balopat mentioned this pull request Nov 15, 2018
@balopat
Copy link
Contributor

balopat commented Nov 15, 2018

I fixed this in #1281. Thank you for raising the awareness for this. I am closing this PR now.

@balopat balopat closed this Nov 15, 2018
@emirb emirb deleted the patch-1 branch November 17, 2018 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants