Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix skaffold fix #1123

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Fix skaffold fix #1123

merged 2 commits into from
Oct 9, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 8, 2018

  • Omit empty values in configuration
  • Set the Kind field

@dgageot
Don’t print empty values
553e7ce 
Signed-off-by: David Gageot <[email protected]>
@dgageot
Set Kind on configuration
73260a9 
Signed-off-by: David Gageot <[email protected]>
@codecov-io
Copy link

codecov-io commented Oct 8, 2018 •
edited
Loading

Codecov Report

Merging #1123 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   42.96%   42.96%           
=======================================
  Files          74       74           
  Lines        3403     3403           
=======================================
  Hits         1462     1462           
  Misses       1801     1801           
  Partials      140      140

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b809bd5...73260a9. Read the comment docs.

@dgageot dgageot merged commit 22667e2 into GoogleContainerTools:master Oct 9, 2018
@dgageot dgageot mentioned this pull request Oct 9, 2018
Closed
@dgageot dgageot deleted the fix-1118 branch December 28, 2018 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkubala nkubala nkubala approved these changes

@balopat balopat balopat approved these changes

@r2d4 r2d4 Awaiting requested review from r2d4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgageot @codecov-io @balopat @nkubala