Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labels when deploying to namespace other than default #1115

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 8, 2018

Fixes #1112

Signed-off-by: David Gageot [email protected]

@codecov-io
Copy link

Codecov Report

Merging #1115 into master will decrease coverage by 0.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1115      +/-   ##
==========================================
- Coverage   42.97%   42.96%   -0.02%     
==========================================
  Files          74       74              
  Lines        3402     3403       +1     
==========================================
  Hits         1462     1462              
- Misses       1800     1801       +1     
  Partials      140      140
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/labels.go 0% <0%> (ø) ⬆️
pkg/skaffold/deploy/kustomize.go 36.23% <0%> (ø) ⬆️
pkg/skaffold/deploy/kubectl.go 51.21% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 227ed25...f25a922. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgageot dgageot merged commit ac64849 into GoogleContainerTools:master Oct 8, 2018
@dgageot dgageot deleted the fix-1112 branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants