Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing parenthesis #1089

Merged
merged 1 commit into from
Oct 4, 2018

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Oct 4, 2018

$ skaffold --help
...
Flags:
  -v, --verbosity string   Log level (debug, info, warn, error, fatal, panic (default "warning")
...

Add a parenthesis at the end

Signed-off-by: David Gageot [email protected]

Signed-off-by: David Gageot <[email protected]>
@codecov-io
Copy link

codecov-io commented Oct 4, 2018

Codecov Report

Merging #1089 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1089   +/-   ##
=======================================
  Coverage   42.43%   42.43%           
=======================================
  Files          72       72           
  Lines        3280     3280           
=======================================
  Hits         1392     1392           
  Misses       1754     1754           
  Partials      134      134
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/cmd.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f96420...778d5da. Read the comment docs.

Copy link
Contributor

@balopat balopat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dgageot dgageot merged commit b0a57aa into GoogleContainerTools:master Oct 4, 2018
@dgageot dgageot deleted the fix-parenthesis branch December 28, 2018 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants