-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit deactivation of profile via CLI argument #3988
Comments
Hi @masih I'm sorry there's no such feature. Shouldn't be too complicated to add, though |
All the work happens here: skaffold/pkg/skaffold/schema/profiles.go Line 39 in d402799
|
Thanks for the quick response @dgageot 🍻 it would be fantastic if that's added. This could even be a flag to disable "auto-activation" and make profile enablement explicit. I think this would be useful in CI build environment just to assert behaviour and avoid unwanted accidental ones. Outside of that, it could be useful for capturing say integration tests in a profile that are run explicitly against another profile after that profile is deployed. After tests are run one would want to clean up the test resources. That option would assure that I won't accidentally delete application resources as part of cleaning up integration test resources. Without it the alternative is to avoid auto-activation completely, which results in a less convenient developer experience. Does that make sense? |
Makes sense to me. I can definitely see where you would want to be very explicit about which profiles to use in a CI environment. @dgageot - any additional feedback? |
Profile auto-activation was fixed by #4034 |
Fixes GoogleContainerTools#3988 Signed-off-by: David Gageot <[email protected]>
Fantastic many thanks 🍻 |
Is there a way to explicitly disable a profile that may have been automatically activated?
The text was updated successfully, but these errors were encountered: