Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skaffold can't use the latest gcr.io/cloud-builders/mvn to with with Jib on GCB #2546

Closed
dgageot opened this issue Jul 25, 2019 · 0 comments · Fixed by #2548
Closed

Skaffold can't use the latest gcr.io/cloud-builders/mvn to with with Jib on GCB #2546

dgageot opened this issue Jul 25, 2019 · 0 comments · Fixed by #2548
Assignees
@dgageot
Labels
build/gcb build/jib kind/feature-request

Comments

@dgageot
Copy link
Contributor

dgageot commented Jul 25, 2019

The version of the gcr.io/cloud-builders/mvn builder that Skaffold uses on GCB to build jib artifacts was pinned a while ago to a version that contained docker.

The reason is that Skaffold runs jib:dockerBuild and lets Cloud Build push the result image. Instead, it could use jib:build and let Jib push the image itself. Which was complicated because of GoogleContainerTools/jib#1500
@dgageot dgageot self-assigned this Jul 25, 2019
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 25, 2019
@dgageot
Support recent maven, for Jib on GCB
6a6734d 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
@dgageot dgageot mentioned this issue Jul 25, 2019
Merged
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 25, 2019
@dgageot
Support recent maven, for Jib on GCB
710cce5 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 25, 2019
@dgageot
Support recent maven, for Jib on GCB
58fb8f0 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 26, 2019
@dgageot
Support recent maven, for Jib on GCB
ad912d1 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 26, 2019
@dgageot
Support recent maven, for Jib on GCB
c5f1e59 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 28, 2019
@dgageot
Support recent maven, for Jib on GCB
067a7fe 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 29, 2019
@dgageot
Support recent maven, for Jib on GCB
419b230 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 30, 2019
@dgageot
Support recent maven, for Jib on GCB
df2ebc6 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit to dgageot/skaffold that referenced this issue Jul 30, 2019
@dgageot
Support recent maven, for Jib on GCB
e0e3eb8 
Fix GoogleContainerTools#2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>
dgageot added a commit that referenced this issue Jul 31, 2019
@dgageot
Improve Jib support on gcb (#2548)
e80a637 
* Support recent maven, for Jib on GCB

Fix #2546

Also took the opportunity to improve tests a bit.

Should give builds that are slightly faster since
they will by default use a builder image that's
already cached on GCB.

Signed-off-by: David Gageot <[email protected]>

* Use a more recent version of maven

Signed-off-by: David Gageot <[email protected]>

* Show more logs when building with Jib

Signed-off-by: David Gageot <[email protected]>

* Add a jib gradle integration test

Signed-off-by: David Gageot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgageot dgageot

Labels
build/gcb build/jib kind/feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Jib support on gcb dgageot/skaffold
1 participant
@dgageot