Skip to content

Commit

Permalink
Remove commented test-case
Browse files Browse the repository at this point in the history
Signed-off-by: Cornelius Weig <[email protected]>
  • Loading branch information
corneliusweig committed Aug 13, 2019
1 parent 91a1d0d commit c7ef098
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions pkg/skaffold/config/util_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -194,24 +194,6 @@ func Test_getConfigForKubeContextWithGlobalDefaults(t *testing.T) {
DefaultRepo: "my-public-registry",
},
},
/* todo(corneliusweig): this behavior can be enabled with `mergo.WithAppendSlice` -> clarify requirements
{
name: "merge global and context-specific insecure-registries",
kubecontext: someKubeContext,
cfg: &GlobalConfig{
Global: &ContextConfig{
InsecureRegistries: []string{"good.io", "better.io"},
},
ContextConfigs: []*ContextConfig{{
Kubecontext: someKubeContext,
InsecureRegistries: []string{"bad.io", "worse.io"},
}},
},
expectedConfig: &ContextConfig{
Kubecontext: someKubeContext,
InsecureRegistries: []string{"bad.io", "worse.io", "good.io", "better.io"},
},
},*/
}
for _, test := range tests {
testutil.Run(t, test.name, func(t *testutil.T) {
Expand Down

0 comments on commit c7ef098

Please sign in to comment.