Skip to content

Commit

Permalink
Fix Git Tagger name
Browse files Browse the repository at this point in the history
Fixes #472

Signed-off-by: David Gageot <[email protected]>
  • Loading branch information
dgageot committed Apr 27, 2018
1 parent 2ed4b03 commit bccfee0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion pkg/skaffold/config/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ kind: Config
apiVersion: skaffold/v1alpha2
kind: Config
build:
tagPolicy:
gitCommit: {}
artifacts:
- imageName: example
deploy:
Expand Down Expand Up @@ -96,7 +98,7 @@ func TestParseConfig(t *testing.T) {
dev: true,
expected: config(
withLocalBuild(
withTagPolicy(v1alpha2.TagPolicy{ShaTagger: &v1alpha2.ShaTagger{}}),
withTagPolicy(v1alpha2.TagPolicy{GitTagger: &v1alpha2.GitTagger{}}),
withDockerArtifact("example", ".", "Dockerfile"),
),
withDeploy("example"),
Expand Down
2 changes: 1 addition & 1 deletion pkg/skaffold/schema/v1alpha2/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ type BuildConfig struct {

// TagPolicy contains all the configuration for the tagging step
type TagPolicy struct {
GitTagger *GitTagger `yaml:"git"`
GitTagger *GitTagger `yaml:"gitCommit"`
ShaTagger *ShaTagger `yaml:"sha256"`
EnvTemplateTagger *EnvTemplateTagger `yaml:"envTemplate"`
}
Expand Down

0 comments on commit bccfee0

Please sign in to comment.