Skip to content

Commit

Permalink
feat: configure verify and exec commands to emit metrics (#9013)
Browse files Browse the repository at this point in the history
* feat: configure render, verify, and exec commands to emit metrics

* fix: remove render command from tracking due to corrupted output data
  • Loading branch information
renzodavid9 committed Sep 7, 2023
1 parent 8f37e9d commit 9d7c3c6
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions cmd/skaffold/app/cmd/exec.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ func NewCmdExec() *cobra.Command {
WithExample("Execute a defined action that uses an image built from Skaffold. First, build the images", "build --file-output=build.json").
WithExample("Then use the built artifacts", "exec <action-name> --build-artifacts=build.json").
WithCommonFlags().
WithHouseKeepingMessages().
WithArgs(func(cmd *cobra.Command, args []string) error {
if len(args) != 1 {
log.Entry(context.TODO()).Errorf("`exec` requires exactly one action to execute")
Expand Down
2 changes: 1 addition & 1 deletion pkg/skaffold/instrumentation/meter.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ var (
)

func init() {
MeteredCommands.Insert("apply", "build", "delete", "deploy", "dev", "debug", "filter", "generate_pipeline", "render", "run", "test")
MeteredCommands.Insert("apply", "build", "delete", "deploy", "dev", "debug", "filter", "generate_pipeline", "render", "run", "test", "verify", "exec")
doesBuild.Insert("build", "render", "dev", "debug", "run")
doesDeploy.Insert("apply", "deploy", "dev", "debug", "run")
}
Expand Down

0 comments on commit 9d7c3c6

Please sign in to comment.