Skip to content

Commit

Permalink
chore: remove latest tagging in release process 2.0 (#8985)
Browse files Browse the repository at this point in the history
* chore: remove latest tagging from relase process

* chore:  configure minikube to a static version in github ci  (#8951)

* chore: ..

* chore: make minikube version a variable
  • Loading branch information
ericzzzzzzz authored Aug 4, 2023
1 parent 25aeee7 commit 8421ff8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
5 changes: 3 additions & 2 deletions .github/workflows/integration-linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
ko_version: [0.4.0]
kompose_version: [1.21.0]
kpt_version: [1.0.0-beta.13]
minikube_version: [1.30.1]
gcloud_sdk_version: [410.0.0]
container_structure_tests_version: [1.8.0]
integration_test_partitions: [0, 1, 2, 3]
Expand Down Expand Up @@ -116,10 +117,10 @@ jobs:
echo '{}' > ${HOME}/.docker/config.json
mkdir -p ${HOME}/.m2/ && cp ./hack/maven/settings.xml ${HOME}/.m2/settings.xml
- name: Install Minikube from minikube master branch @HEAD and start cluster
- name: Install Minikube and start cluster
if: ${{ env.NON_DOCS_FILES_CHANGED != 0 }}
run: |
curl -Lo minikube https://storage.googleapis.com/minikube-builds/master/minikube-linux-amd64
curl -Lo minikube https://github.com/kubernetes/minikube/releases/download/v${{ matrix.minikube_version }}/minikube-linux-amd64
sudo install minikube /usr/local/bin/minikube
minikube start --profile=minikube --driver=docker
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ release: $(BUILD_DIR)/VERSION
--build-arg VERSION=$(VERSION) \
-f deploy/skaffold/Dockerfile \
--target release \
-t gcr.io/$(GCP_PROJECT)/skaffold:latest \
-t gcr.io/$(GCP_PROJECT)/skaffold:$(VERSION) \
.

Expand Down

0 comments on commit 8421ff8

Please sign in to comment.