Skip to content

Commit

Permalink
Fix lint errors for TODO comments in import block
Browse files Browse the repository at this point in the history
Adding the TODO in the import block resulted in gci linter errors:
https://app.travis-ci.com/github/GoogleContainerTools/skaffold/jobs/530642848#L313
  • Loading branch information
halvards committed Aug 11, 2021
1 parent 84777c7 commit 5158e66
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions pkg/skaffold/build/ko/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ limitations under the License.

package ko

// TODO(halvards)[08/11/2021]: Replace the latestV1 import path with the
// real schema import path once the contents of ./schema has been added to
// the real schema in pkg/skaffold/schema/latest/v1.
import (
"context"
"fmt"
Expand All @@ -26,9 +29,6 @@ import (
"github.com/google/ko/pkg/build"
"github.com/google/ko/pkg/publish"

// TODO(halvards)[08/11/2021]: Replace the latestV1 import path with the
// real schema import path once the contents of ./schema has been added to
// the real schema in pkg/skaffold/schema/latest/v1.
// latestV1 "github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/latest/v1"
latestV1 "github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/ko/schema"
)
Expand Down
6 changes: 3 additions & 3 deletions pkg/skaffold/build/ko/build_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ limitations under the License.

package ko

// TODO(halvards)[08/11/2021]: Replace the latestV1 import path with the
// real schema import path once the contents of ./schema has been added to
// the real schema in pkg/skaffold/schema/latest/v1.
import (
"bytes"
"context"
Expand All @@ -27,9 +30,6 @@ import (
"github.com/google/ko/pkg/build"
"github.com/google/ko/pkg/publish"

// TODO(halvards)[08/11/2021]: Replace the latestV1 import path with the
// real schema import path once the contents of ./schema has been added to
// the real schema in pkg/skaffold/schema/latest/v1.
// latestV1 "github.com/GoogleContainerTools/skaffold/pkg/skaffold/schema/latest/v1"
latestV1 "github.com/GoogleContainerTools/skaffold/pkg/skaffold/build/ko/schema"
"github.com/GoogleContainerTools/skaffold/pkg/skaffold/docker"
Expand Down

0 comments on commit 5158e66

Please sign in to comment.