minor tweaks

pkg/skaffold/initializer/build/builders.go

@@ -37,6 +37,7 @@ type InitBuilder interface {
 	Describe() string
 
 	// ArtifactType returns the type of the artifact to be built.  Paths should be relative to the workspace.
+	// To make skaffold.yaml more portable across OS-es we should always generate /-delimited filepaths.
 	ArtifactType(workspace string) latest.ArtifactType
 
 	// ConfiguredImage returns the target image configured by the builder, or an empty string if no image is configured.

pkg/skaffold/initializer/build/util.go

@@ -75,7 +75,7 @@ func Artifacts(artifactInfos []ArtifactInfo) []*latest.Artifact {
 		}
 
 		if workspace != "." {
-			// to make skaffold.yaml more portable across OS-es we should always generate /-delimited filePaths
+			// to make skaffold.yaml more portable across OS-es we should always generate /-delimited filepaths
 			artifact.Workspace = filepath.ToSlash(workspace)
 		}
 

pkg/skaffold/initializer/init_test.go

@@ -36,7 +36,7 @@ import (
 func TestDoInit(t *testing.T) {
 	tests := []struct {
 		name             string
-		shouldSkip       func() bool
+		shouldSkip       bool
 		dir              string
 		config           initconfig.Config
 		expectedError    string
@@ -93,7 +93,7 @@ func TestDoInit(t *testing.T) {
 		},
 		{
 			name:       "windows paths use forward slashes",
-			shouldSkip: func() bool { return runtime.GOOS != "windows" },
+			shouldSkip: runtime.GOOS != "windows",
 			dir:        `testdata\init\windows`,
 			config: initconfig.Config{
 				Force: true,
@@ -228,7 +228,7 @@ See https://skaffold.dev/docs/pipeline-stages/deployers/helm/ for a detailed gui
 	}
 	for _, test := range tests {
 		testutil.Run(t, test.name, func(t *testutil.T) {
-			if test.shouldSkip != nil && test.shouldSkip() {
+			if test.shouldSkip {
 				t.Logf("Skipped test %q", test.name)
 				return
 			}