-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ko): Do not add
-trimpath
when debugging
`ko` adds the `-trimpath` flag to `go build` by default, as this aids in achieving reproducible builds. The `-trimpath` flag removes file system paths from the resulting binary, and this makes interactive debugging more difficult. This change instructs `ko` to _not_ add the `-trimpath` flag when users run `skaffold debug` with the `ko` builder. Bumps the `ko` version to pick up the `Trimpath` build option. Also, simplifies the `ko` example config since it's no longer necessary to add a non-empty `flags` field to `skaffold.yaml` to allow for interactive debugging. Fixes: #6843 Tracking: #6041
- Loading branch information
Showing
5 changed files
with
52 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.