-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for self signed certicate #618
Conversation
Hi @velo , thanks for writing up this extensive documentation! We'll take a look at this soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just adding the default password (changeit) to document, too?
I think it should also work with -D argument, but I didn't tested that.
What password? Not sure what you mean. |
Default password for Java keystore, that is "changeit". I think it should be in document. |
Mine was not password protected, which step was that? |
At the end of step one it can mentioned, that
|
To help with the confusion about the password protection of cacerts: Since version 5.2 KeyStore Explorer automatically tries to open cacerts with the default password ("changeit"). It only prompts for a password if this fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @velo for this contribution! I made a couple of suggestions.
docs/self_sign_cert.md
Outdated
@@ -0,0 +1,51 @@ | |||
# Accessing private docker registry with self signed certificate | |||
|
|||
Currently, `jib` do not support docker registries with self signed `https` certificate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not -> does not
self signed certificate -> self-signed certificates
docs/self_sign_cert.md
Outdated
|
||
## Using KeyStore Explorer | ||
|
||
The easiest way to import the self signed certificate into jvm is using the [KeyStore Explorer](http://keystore-explorer.org/). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the self signed -> a self-signed
jvm -> JVM
docs/self_sign_cert.md
Outdated
|
||
Currently, `jib` do not support docker registries with self signed `https` certificate. | ||
|
||
The only way to get `jib` working is to import the self signed certificate into jvm `CA Certificates Keystore`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
Jib uses the JRE's list of approved CA Certificates to validate SSL certificates. The following instructions describe how to add a registry's self-signed certificate to the JRE's approved CAs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about also adding
"The certificate will be trusted at the JRE level, affecting all Java applications running on it. You will also need to re-import the certificate when you use a different JRE or upgrade it."
|
||
### Import certificate | ||
|
||
* Launch `KeyStore Explorer` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My 2¢: it would be easier to have the user use Open an existing KeyStore and navigate to the cacerts
file (with default password changeit
).
Then there are two approaches:
- if the user has the self-signed certificate, they can import it.
- if they don't have the self-signed certificate, they can import it from the running service with the Examine SSL option. It allows importing the certificate directly into the keystone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this import process has multiple possible ways to be done.... I describe the one I used
@chanseokoh @briandealwis changes applied |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This looks good and will work.
Create doc with the workaround discuessed on #543 (comment)