Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add timeout for docker info read to prevent Jib from getting stuck indefinitely #4319

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

mpeddada1
Copy link
Contributor

@mpeddada1 mpeddada1 commented Oct 16, 2024

#4311

  1. Fixed gradle and maven integration tests to make mock docker executable output OSType and Architecture. As discovered in Investigate SingleProjectIntegrationTest#testBuild_dockerClient getting stuck indefinitely #4311 (comment), Jib ran successfully when the docker client was used but was getting stuck indefinitely when a custom docker client was provided through the jib.dockerClient feature.
  2. [Improvement] Added timeout to ensure that Jib doesn't indefinitely get stuck when an output from docker info isn't returned, instead we throw an exception with a helpful message.

Verified locally through ./gradlew integrationTest

@mpeddada1 mpeddada1 merged commit aac44d3 into master Oct 25, 2024
11 checks passed
@mpeddada1 mpeddada1 deleted the address-nightly-ubuntu branch October 25, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants