Fixes #3898, log an info instead of o warning when entrypoint makes t… #3904

rmannibucau · 2022-12-29T18:55:45Z

…he image to ignore jvm parameters

Before filing a pull request, make sure to do the following:

Create a new issue at https://github.com/GoogleContainerTools/jib/issues/new/choose.
Ensure that your implementation plan is approved by the team.
Verify that integration tests and unit tests are passing after the change.
Address all checkstyle issues. Refer to the style guide.

This helps to reduce the chance of having a pull request rejected.

…n entrypoint makes the image to ignore jvm parameters

mpeddada1

Thank you for your contribution @rmannibucau!

mpeddada1 · 2023-01-06T22:33:04Z

...on/src/main/java/com/google/cloud/tools/jib/plugins/common/PluginConfigurationProcessor.java

+      // in a multi-module project it is not rare to configure a ton of jvmflags, sometimes
+      // classpath
+      // but having a submodule overriding entrypoint and ignoring all that is intended when such a
+      // config is done
+      // so just log it for user awareness but as an INFO, it is NOT an error


nit: Thanks for documenting this! This comment may be better suited as a PR description.
Comments are usually recommended when it is not entirely clear what the code is doing but in this case, the use of LogEvent.info is self-explanatory so it should be safe to omit it.

Intent was to document it shouldnt be switched to warn in code - not sure anyone would use blame to check that but happy to drop it if you think it is better

Intent was to document it shouldnt be switched to warn in code -

I see! Increasing the log severity (to warnings or errors) needs to be done thoughtfully regardless so this shouldn't be a major concern. This change would also help us make the style be consistent with other classes in the repo.