-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add registry mirror config to jib-core API and Jib global config #2999
Conversation
This is ready for review. I'm curious what you feel about storing and returning a map and handling errors in this way. |
jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
Outdated
Show resolved
Hide resolved
description or bug? |
Sorry, updated the doc. Just realized I forget updating the jib-core |
Nah, I will update |
jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
Show resolved
Hide resolved
jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I got here late, but generally I think we use the style of abstract/interface for method inputs and return types? So ListMultimap is the type we expose and ImmutableListMultimap is an impl detail?
jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
Outdated
Show resolved
Hide resolved
jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java
Outdated
Show resolved
Hide resolved
I think this looks good to me |
Ah right, thanks for clarifying! In that case I don't think my comments apply here. Sorry about that. |
Towards #1396.
Containerizer.withRegistryMirrors(...)
to the jib-core API.registryMirrors
to the global Jib config.