Don't wrongly assume Spring Boot isn't configured when empty <configuration> #2693
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2692.
Reverts the fix of #2688, which only avoided NPE but wrongly assumed Spring Boot isn't configured by returning
Optional.empty()
. Instead, this PR returns an emptyXpp3Dom
to signal that Spring Boot is configured.Note that we do have a Spring Boot integration test for checking if we accidentally containerize a fat JAR. However, as mentioned here, this doesn't seem reproducible with a default setup. To hit both #2687 and #2692, it may be a multi-module Spring Boot setup (although I can't conclusively confirm this).