Fix missing env in maven docker context generator #1152
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coollog
reviewed
Oct 16, 2018
| @@ -139,7 +139,7 @@ private static String mapToDockerfileString(Map<String, String> map, String comm | |||
| @Nullable private String baseImage; | |||
| private List<String> entrypoint = Collections.emptyList(); | |||
| private List<String> javaArguments = Collections.emptyList(); | |||
| private Map<String, String> environment = Collections.emptyMap(); | |||
| @Nullable private Map<String, String> environment; | |||
There was a problem hiding this comment.
Should we have this be consistent with the others and not be nullable?
There was a problem hiding this comment.
entrypoint and javaArguments actually become nullable in a future change, I think.
There was a problem hiding this comment.
Ah right. I think if we make environment nullable, we should make exposedPorts and labels nullable too but that change can go in the post-release PR.
coollog
approved these changes
Oct 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Again, changes for Maven 0.9.13 patch (skipping 0.9.12 to stay even with the Gradle plugin). Will close and re-open with the release PR after approval.