New JavaLayerConfiguration API for more flexibility #1049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coollog
reviewed
Sep 27, 2018
jib-core/src/main/java/com/google/cloud/tools/jib/frontend/JavaDockerContextGenerator.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/frontend/JavaLayerConfigurations.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/frontend/JavaLayerConfigurations.java
Outdated
Show resolved
Hide resolved
jib-core/src/main/java/com/google/cloud/tools/jib/frontend/JavaLayerConfigurations.java
Outdated
Show resolved
Hide resolved
| * sourceFile} | ||
| * @return this | ||
| */ | ||
| public Builder addDependencyFileRecursive(Path sourceFile, AbsoluteUnixPath pathInContainer) { |
There was a problem hiding this comment.
Is it okay if all files are added recursively? (aka are the non-rescursive add...File methods necessary?)
There was a problem hiding this comment.
I tried to be in line with LayerConfiguration having both recursive and non-recursive methods, but now I think it is possible to cover all cases only with recursive adds. Then perhaps I can rename add...FileRecursive() to just add...File.
There was a problem hiding this comment.
Now I remember. The non-recursive case is useful when the caller is walking a directory, enumerating all files and directories and adding each path.
coollog
approved these changes
Sep 27, 2018
|
Added CHANGELOG entries. |
coollog
approved these changes
Sep 27, 2018
This was referenced Sep 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007.
See if this sounds reasonable.
I will see if I can further simplify
GradleLayerConfigurationsandMavenLayerConfigurationswith the new API.