Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds to.tags configuration for Maven. #1026

Merged
merged 3 commits into from
Sep 24, 2018
Merged

Adds to.tags configuration for Maven. #1026

merged 3 commits into from
Sep 24, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Sep 24, 2018

@coollog coollog requested a review from a team September 24, 2018 14:28
@coollog coollog added this to the v0.9.11 milestone Sep 24, 2018
Copy link
Contributor

@TadCordle TadCordle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should update the readme branch with these changes (gradle as well)

*
* @param imageReference the image reference of the built image
* @return the container output
* @throws IOException if an I/O exceptio occurs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I/O exception

@@ -128,6 +155,22 @@ private static String buildAndRunComplex(
return new Command("docker", "run", "--rm", imageReference).run();
}

/**
* Pulls a built image and attemps to run it. Also verifies the container configuration and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempts

@coollog coollog merged commit 6875a05 into master Sep 24, 2018
@coollog coollog deleted the additional-tags-maven branch September 24, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants