Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#276 and #214 request branding the distroless/java images with metadata about the underlying language runtime version. Unfortunately the package information is not available when building the image: all that is available is the actual
.deb
file.distroless/java/BUILD
Lines 12 to 17 in 55b0eb2
Rather than try to extract the
.deb
'scontrol.tar.gz
and itscontrol
file, this PR changes thepackage_manager
to also record a package-to-version mapping (versions
) that is written out with the@package_bundle//file:packages.bzl
.The resulting
packages.bzl
file now looks like:With this change, the
java/BUILD
can now pull in the versions information and useversions[jre_deb]
to annotate the generated images. See my proposed branch for an example.Still outstanding: I'm not sure how the
package_manager_tools
bundle is updated withpackage_manager/package_manager.bzl
.