Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nodejs22 to 22.5.0 #1626

Closed
wants to merge 1 commit into from
Closed

Bump nodejs22 to 22.5.0 #1626

wants to merge 1 commit into from

Conversation

omBratteng
Copy link
Contributor

No description provided.

@omBratteng
Copy link
Contributor Author

@loosebazooka the report diff keeps failing on PRs made by contributors outside the GoogleContainerTools org. If you update the workflow so that it has write permissions to pull_request, it should no longer fail for external contributors.

@smorimoto
Copy link
Contributor

Note that you will have to wait a while to merge this change: nodejs/node#53934

@omBratteng
Copy link
Contributor Author

I guess we probably can skip this version, and wait for a patched version, 22.5.1 probably.

@omBratteng omBratteng closed this Jul 19, 2024
@omBratteng omBratteng mentioned this pull request Jul 19, 2024
Merged
@loosebazooka
Copy link
Member

@loosebazooka the report diff keeps failing on PRs made by contributors outside the GoogleContainerTools org. If you update the workflow so that it has write permissions to pull_request, it should no longer fail for external contributors.

Yeah this was more to detect issues on large scale changes we were doing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omBratteng @smorimoto @loosebazooka