Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed parameter name problems -> problem #171

Merged
merged 1 commit into from
May 27, 2018

Conversation

neil-rubens
Copy link
Contributor

using parameter problem instead of problemes fixes error:
p.s. see discussion https://gitter.im/tensor2tensor/Lobby?at=5b0273bdf04ce53632f379ce

 File "/root/.local/lib/python2.7/site-packages/tensor2tensor/utils/registry.py", line 251, in parse_problem_name
    if problem_name.endswith("_rev"):
AttributeError: 'NoneType' object has no attribute 'endswith'

using parameter `problem` instead of `problemes` fixes error:
p.s. see discussion https://gitter.im/tensor2tensor/Lobby?at=5b0273bdf04ce53632f379ce

```
 File "/root/.local/lib/python2.7/site-packages/tensor2tensor/utils/registry.py", line 251, in parse_problem_name
    if problem_name.endswith("_rev"):
AttributeError: 'NoneType' object has no attribute 'endswith'
```
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@neil-rubens
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

@lakshmanok lakshmanok merged commit dccbfc0 into GoogleCloudPlatform:master May 27, 2018
This was referenced Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants