Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract grouping ID based on configurations #1242

Merged
merged 1 commit into from
Aug 1, 2023
Merged

Extract grouping ID based on configurations #1242

merged 1 commit into from
Aug 1, 2023

Conversation

bryan-lou
Copy link
Contributor

@bryan-lou bryan-lou commented Jul 25, 2023 •
edited by sultan-duisenbay
Loading

Extract the group ID based on primary grouping option or fallback to a default grouping by invocation

@google-oss-prow
Copy link
Contributor

Hi @bryan-lou. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sultan-duisenbay
sultan-duisenbay suggested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@sultan-duisenbay sultan-duisenbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I would suggest to break this down into several parts:

  • extract group ID and write unit tests
  • generate the group and write unit tests
  • process the group and write unit tests

you can remove unnecessary things and let's use regular functions for now with good comments

sultan-duisenbay
sultan-duisenbay approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@sultan-duisenbay sultan-duisenbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM with a couple of nits, please address those and it's good to be merged!

/hold

michelle192837
michelle192837 reviewed Jul 27, 2023
View reviewed changes
pkg/updater/resultstore/resultstore.go Outdated Show resolved Hide resolved
pkg/updater/resultstore/resultstore.go Outdated Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added size/M and removed size/L labels Jul 28, 2023
sultan-duisenbay
sultan-duisenbay suggested changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@sultan-duisenbay sultan-duisenbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change required

pkg/updater/resultstore/resultstore.go Outdated Show resolved Hide resolved
@sultan-duisenbay sultan-duisenbay changed the title Group processed results according to primary and falback grouping configs Extract grouping ID based on configurations Jul 31, 2023
@sultan-duisenbay sultan-duisenbay mentioned this pull request Jul 31, 2023
Closed
sultan-duisenbay
sultan-duisenbay suggested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@sultan-duisenbay sultan-duisenbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the change and squash the commits

pkg/updater/resultstore/resultstore_test.go Outdated Show resolved Hide resolved
@sultan-duisenbay
Copy link
Contributor

/ok-to-test

@sultan-duisenbay
Copy link
Contributor

/lint

@sultan-duisenbay
Copy link
Contributor

/retest

@bryan-lou
Copy link
Contributor Author

/retest

@google-oss-prow google-oss-prow bot added the lgtm label Aug 1, 2023
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-lou, sultan-duisenbay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sultan-duisenbay
Copy link
Contributor

/hold cancel

@google-oss-prow google-oss-prow bot merged commit d69b581 into GoogleCloudPlatform:master Aug 1, 2023
@sultan-duisenbay sultan-duisenbay mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sultan-duisenbay sultan-duisenbay sultan-duisenbay approved these changes

@chases2 chases2 Awaiting requested review from chases2

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@sultan-duisenbay sultan-duisenbay

Labels
approved lgtm ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bryan-lou @sultan-duisenbay @michelle192837