pubsub: fix permadiff with configuring an empty retry_policy. #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:2c219b6d3cf2720fde86ff8b1d65abca8752f7d8] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
shuyama1
and removed request for
a team
modular-magician
merged commit ed6b0b9
into
GoogleCloudPlatform:main
5 of 6 checks passed
modular-magician
deleted the
downstream-pr-2c219b6d3cf2720fde86ff8b1d65abca8752f7d8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes hashicorp/terraform-provider-google#18016
The permadiff arises when users specify an empty retry policy as
retry_policy: {}in their config, but the empty value doesn't get sent to the API and the API subsequently doesn't return aretry_policyin the response. By settingsend_empty_value: trueon theretry_policyproperty, we ensure that the API recognizes the user-configured value.Similar fixes for other resource properties will be investigated and sent in separate PRs.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11834