Fix permadiff that reorders stateful_external_ip blocks on google_compute_instance_group_manager and google_compute_region_instance_group_manager resources
#1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compute_instance_group_manager` and `google_compute_region_instance_group_manager` resources (#9577) * Make `flattenStatefulPolicyStatefulExternalIps` reorder `stateful_external_ip` fields from API to match user's config * Add unit test for new ordering behaviour of `flattenStatefulPolicyStatefulExternalIps` * Whitespace fix * Update test file to be templated to use GA or Beta version of compute client library * Add new test cases where the config contains no `stateful_external_ip` blocks vs 0 or 1+ in API data * Refactor `flattenStatefulPolicyStatefulExternalIps` to make data ordering and data transformation occur in same loop * Add test case for when nic in TF config is missing in the API response, update code to pass * Remove unused test step * Refactor IP sorting code to be reusable * Update `flattenStatefulPolicyStatefulInternalIps` to reorder IPs * Update unit and acceptance tests following refactor [upstream:de43d7035e08ae2494db0b9e91376ec9aa6f5ae0] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
melinath
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-de43d7035e08ae2494db0b9e91376ec9aa6f5ae0
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to (but doesn't close!) this issue : hashicorp/terraform-provider-google#13430
This PR updates code related to
stateful_external_ipblocks in thegoogle_compute_instance_group_manager&google_compute_region_instance_group_managerresources to address a permadiff that proposes re-ordering those blocks. The root of this problem is that the API returns those blocks in a sorted order that doesn't match the user's config. The state will contain data returned from the API, so there's always a plan trying to return to the config-defined order.Prior to this PR, the flattener function for
stateful_external_ipblocks performs a conversion from a map (how the data from the API is presented by the compute Go client library) to an array (how the data is stored in state).This PR updates the flattener function to also re-order data returned by the API so it matches the user's Terraform configuration. This is achieved by passing the
schema.ResourceDatadata for the resource into the flattener, to act as a source of information about the order of those fields in the user's config.Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9577