Remove unnecessary lifecycle ignore_changes from examples #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[upstream:05f4a8d1d6b7e577e7cf563f2b6f10827a8cebd7] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
melinath
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit d1ee0a2
into
GoogleCloudPlatform:main
5 of 6 checks passed
modular-magician
deleted the
downstream-pr-05f4a8d1d6b7e577e7cf563f2b6f10827a8cebd7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of the provided examples ignore
launch_stagechanges. I tested this in my project and I don't think it's harming anything (as I'm not bouncing between beta and GA).Is there any reason a regular user would want this here? If not, I'm thinking it needs to go.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#9571