Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import of bigquery transfer config location #1381

Conversation

modular-magician
Copy link
Collaborator

Fix the custom import code for bigquery transfer config, and make it import the location properly.

Fixes hashicorp/terraform-provider-google#12011

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquerydatatransfer: fixed a bug when importing 'location' of 'google_bigquery_data_transfer_config'

Derived from GoogleCloudPlatform/magic-modules#8768

* Fix import of bigquery transfer config location

* Fix import of bigquery transfer config when name does not contain location

* Fix indentation in bigquery_data_transfer_self_link_as_name_set_location.go.erb

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner September 6, 2023 13:08
@modular-magician modular-magician requested review from ScottSuarez and removed request for a team September 6, 2023 13:08
@modular-magician modular-magician merged commit 916951b into GoogleCloudPlatform:main Sep 6, 2023
@modular-magician modular-magician deleted the downstream-pr-050e27531457f525b221ce231b92a7820ffc1a08 branch November 18, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

location is set to null on terraform import for bigquery transfer config
1 participant