Skip to content

Commit

Permalink
Compute - Add update support for Network IP when changing network/sub…
Browse files Browse the repository at this point in the history
…network (#4030) (#549)

* Compute - Add update support for Network IP when changing network/subnetwork

* add field required by beta provider

* error check for d.ForceNew

* refactor functions into own file. introduce network-interface-helper

* refresh instance after deleting alias config

* correct bad merge

* spelling fix

* check error

* Add forcenew unit test

* resolve build issue

* Update third_party/terraform/tests/resource_compute_instance_test.go.erb

Co-authored-by: Cameron Thornton <[email protected]>

* Update third_party/terraform/tests/resource_compute_instance_test.go.erb

Co-authored-by: Cameron Thornton <[email protected]>

* error couldn't convert to string

* to type string

* Refactored some test code for cleaner style and condensed some if statements

* resolve merge issue with megan's change

* update network interface helper to promote better go readability

* fixed instances where incorrect name was referenced

* removed extraneous dependencies and extrapolated self mutating operations

* scrap refactor. only extrapolate functions when needed.

* error check

* resolved some fomatting and comment concerns.

* find a comment a nice cozy new home on the hill side amongst all its comment friends. Truly truly a beautiful site to behold. Please be well and safe comment because the world needs you. YOU TOO are important

* a comma boi

* another commma for the party

Co-authored-by: Cameron Thornton <[email protected]>
Signed-off-by: Modular Magician <[email protected]>

Co-authored-by: Cameron Thornton <[email protected]>
  • Loading branch information
modular-magician and c2thorn authored Oct 13, 2020
1 parent cdcaa97 commit f5c0737
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions google/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ type TerraformResourceData interface {
}

type TerraformResourceDiff interface {
HasChange(string) bool
GetChange(string) (interface{}, interface{})
Get(string) interface{}
Clear(string) error
Expand Down

0 comments on commit f5c0737

Please sign in to comment.