feat: Possibility to ignore external updates. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some fields can updated "outside of terraform" i.e. when pushing a docker image tag in a CICD pipeline. This backwards-compatible change allows to explicitly ignore external changes of certain fields (i.e. update_time)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Ping @prabhu34 |
|
Hey @prabhu34 can you prioritize reviewing and merging this PR? Thanks. |
|
(re-opened to re-trigger stuck lint) |
|
/gcbrun |
apeabody
requested changes
Dec 30, 2024
There was a problem hiding this comment.
Thanks for the contribution @oerd!
This is from the lint test:
terraform_validate .
╷
│ Error: Terraform encountered problems during initialisation, including problems
│ with the configuration, described below.
│
│ The Terraform configuration must be valid before initialization so that
│ Terraform can determine which modules and providers need to be installed.
│
│
╵
╷
│ Error: Invalid expression
│
│ on main.tf line 187, in resource "google_artifact_registry_repository" "repo":
│ 187: ignore_changes = var.ignore_changes
│
│ A static list expression is required.
╵
terraform_validate ./examples/gar_docker_repo
╷
│ Error: Invalid expression
│
│ on ../../main.tf line 187, in resource "google_artifact_registry_repository" "repo":
│ 187: ignore_changes = var.ignore_changes
│
│ A static list expression is required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields can be updated "outside of terraform" i.e. when pushing a docker image tag in a CICD pipeline. This backwards-compatible change allows to explicitly ignore external changes of certain fields (i.e. update_time)
fixes #47