This repository has been archived by the owner on Jan 14, 2023. It is now read-only.
Add Java samples for slash commands. #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Circle to test the Java samples.
|
(I cancelled Travis to free up the queue, since it's not actually running any Java tests.) |
lesv
suggested changes
Nov 4, 2016
|
|
||
| <p>Follow the | ||
| <a href="https://github.com/GoogleCloudPlatform/slack-samples/tree/master/java/command">instructions | ||
| for this sample</a> to configure and modify this sample. |
| servletUnderTest.doPost(mockRequest, mockResponse); | ||
| assertThat(responseWriter.toString()).isEqualTo("Hello, Jane Doe."); | ||
| } | ||
| } |
|
|
||
| - Type `/greet` in your Slack team. | ||
|
|
||
| You should see the text `Hello, world.` in response. |
There was a problem hiding this comment.
Sounds good to me. I've pulled the common bits out into templates here: GoogleCloudPlatform/java-docs-samples#405
| <module name="SuppressWarningsFilter" /> | ||
| <!-- Allow silencing with comment http://stackoverflow.com/questions/4023185 --> | ||
| <module name="SuppressionCommentFilter" /> | ||
| </module> |
There was a problem hiding this comment.
Do we really need to check this in everywhere?
There was a problem hiding this comment.
No, I figured out how to bundle this in the resources of the parent: GoogleCloudPlatform/java-repo-tools#45
This means we don't have to bundle google-checks.xml. Also, add templates for READMEs.
Fixes copy-paste error.
Regenerated with `markdown-pp`.
lesv
approved these changes
Nov 11, 2016
|
LGTM - Once you get something to pass |
I forgot to remove the -SNAPSHOT when testing from the `1-start/pom.xml`. By using the root `pom.xml`, mistakes like this should be prevented.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Circle to test the Java samples.
@lesv PTAL