-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(samples): Add Dataflow to Pub/Sub snippet #11104
docs(samples): Add Dataflow to Pub/Sub snippet #11104
Conversation
Adds a snippet that shows how to write messages to Pub/Sub from Dataflow.
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
dataflow/snippets/noxfile_config.py
Outdated
"ignored_versions": ["2.7", "3.7", "3.9", "3.10", "3.12"], | ||
# Old samples are opted out of enforcing Python type hints | ||
# All new samples should feature them | ||
"enforce_type_hints": False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For new samples we recommend using type hints, they make the code more self-documented and easier to understand.
Type hints can sometimes be a little tricky to figure out, so feel free to ask if you need any help with any of them.
I believe you can run the type checks with nox -s lint
(more info).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks -- I added type hints. I'm not super familiar with them, so let me know if anything looks wonky!
Description
Adds a snippet that shows how to write messages to Pub/Sub from Dataflow.
Bug: b/310239684
Doc bug: b/318728052 (Parent doc bug for context: b/309130866)
Checklist
nox -s py-3.9
(see Test Environment Setup)nox -s lint
(see Test Environment Setup)