Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus 2.53.1 release #193

Draft
wants to merge 15 commits into
base: feature/v2.53.1
Choose a base branch
from
Draft

Prometheus 2.53.1 release #193

wants to merge 15 commits into from

Conversation

TheSpiritXIII
Copy link
Member

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 19, 2024
View reviewed changes
Dockerfile
ARG IMAGE_BASE_DEBUG=gcr.io/distroless/static-debian11:debug
ARG IMAGE_BASE=gke.gcr.io/gke-distroless/libc@sha256:4f834e207f2721977094aeec4c9daee7032c5daec2083c0be97760f4306e4f88

FROM ${IMAGE_BUILD_GO} AS gobase

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
Dockerfile
FROM ${IMAGE_BUILD_GO} AS gobase

# Compile the UI assets.
FROM ${IMAGE_BUILD_NODEJS} as assets

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
Dockerfile
# Configure distroless base image like the upstream Prometheus image.
# Since the directory and symlink setup needs shell access, we need yet another
# intermediate stage.
FROM ${IMAGE_BASE_DEBUG} as appbase

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
Dockerfile
RUN make npm_licenses

# Build the actual Go binary.
FROM gobase as buildbase

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
Dockerfile
RUN ["/busybox/sh", "-c", "ln -s /usr/share/prometheus/console_libraries /usr/share/prometheus/consoles/ /etc/prometheus/"]
RUN ["/busybox/sh", "-c", "mkdir -p /prometheus"]

FROM ${IMAGE_BASE}

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 5: containerImage not pinned by hash
Click Remediation section below to solve this issue
@TheSpiritXIII TheSpiritXIII changed the title The spirit xiii/v2.53.1 Prometheus 2.53.1 release Jul 19, 2024
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/v2.53.1 branch 2 times, most recently from a0a856b to a0311b2 Compare July 19, 2024 18:07
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/v2.53.1 branch from a0311b2 to 308a8d8 Compare July 22, 2024 17:58
TheSpiritXIII and others added 13 commits July 22, 2024 15:19
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/v2.53.1 branch from 308a8d8 to f491a43 Compare July 22, 2024 19:20
@vm250200 vm250200 mentioned this pull request Jul 25, 2024
Open
@bernot-dev
Copy link
Collaborator

/prombench

@gmp-bot
Copy link
Collaborator

gmp-bot commented Oct 18, 2024

This benchmark run compares this PR (#193) with version v2.45.3-gmp.9-gke.0 of the GMP Collector.

After a successful deployment, the benchmarking results can be viewed on the Cloud Monitoring Dashboard.

To cancel or stop the benchmark run, comment /prombench cancel on this PR.

To view the results of the profiling process you can run the following commands. After running the commands, go to localhost:31802/profiles to view your profiling results after a few minutes.

gcloud container clusters get-credentials prombench --zone us-east4-a --project gpe-test-1
kubectl config use-context gke_gpe-test-1_us-east4-a_prombench
kubectl port-forward services/parca 31802:80

@TheSpiritXIII
Copy link
Member Author

@bernot-dev hi, note that this PR is missing some of the recent changes to be able to change Google Cloud settings via config files.

@bernot-dev
Copy link
Collaborator

@TheSpiritXIII Yeah, that's fine. I'm not preparing for release. Just seeing if anything interesting shows up in the profiling data for my presentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TheSpiritXIII @bernot-dev @gmp-bot @pintohutch @bwplotka