-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump otelhttp to resolve CVE; Bump Go version; Bump golangci-lint + adjusted lint configs; critical copylock fix #120
Bump otelhttp to resolve CVE; Bump Go version; Bump golangci-lint + adjusted lint configs; critical copylock fix #120
Conversation
This resolves https://nvd.nist.gov/vuln/detail/CVE-2023-45142 by bumping otelhttp to v0.45.0. It's a follow-up to #113. I had to bump the otlptrace packages to v1.19.0 to make `go mod tidy` happy as well.
This fixed a failing unit test in tracing_test.go and was made upstream in prometheus/prometheus#12964.
Trying like hell to get the CI to pass, but hitting issues left and right...gonna let this bake overnight |
This reverts commit 073b7ec.
…tant copylock lint issue. Signed-off-by: bwplotka <[email protected]>
We could downgrade golangci-lint, but soon we might have another version of Go or some important fix, so I would use latest golangci-lint on our supported fork versions. Solid question is--can we disable golangci-lint-ing. We mostly import and inject export package here, but also fixed multiple security issues... it would be nice to lint on important things. Fixing less important linting errors is adding too much changes to our fork diff vs upstream for no good reason e.g. readability pointers:
I propose adjusting certain linters:
I fixed one govet signal which makes sense (also fixed in latest upstream) https://github.com/prometheus/prometheus/blob/main/web/web.go#L750 TL;DR we need the latest Prometheus version as our main GMP collector version ASAP ;p |
Signed-off-by: bwplotka <[email protected]>
Another fix - skipping linting of some documentation code, somehow downloading does not work. |
Totally agree about the need to bump it (@TheSpiritXIII has a pending PR in #562) - though I wonder if we should be aiming for 2.45 for LTS support. |
Thanks @bwplotka for the contributions here! Merging with your changes. |
Crap - I mean to squash these commits into one. Gonna fast-and-loose just do that in the release branch 😬 |
This resolves https://nvd.nist.gov/vuln/detail/CVE-2023-45142 by bumping otelhttp to v0.45.0. It's a follow-up to
#113.
I had to bump the otlptrace packages to v1.19.0 to make
go mod tidy
happy as well.