Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secretless Basic Auth support #650

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

TheSpiritXIII
Copy link
Member

Partial fix for #241. This change adds Basic Auth support but only usernames for now. Passwords are planned to be represented with secrets in a future PR.

Integration tests are planned for a future PR.

@github-actions github-actions bot requested a review from bernot-dev October 24, 2023 17:57
@TheSpiritXIII TheSpiritXIII marked this pull request as ready for review October 24, 2023 17:59
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/secretless-basic-auth branch 2 times, most recently from 0a068c2 to 09e51da Compare October 27, 2023 16:29
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/secretless-basic-auth branch 2 times, most recently from a833788 to 9305f0b Compare November 23, 2023 01:06
Copy link
Collaborator

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a documentation nit (:

pkg/operator/apis/monitoring/v1/types.go Outdated Show resolved Hide resolved
@TheSpiritXIII TheSpiritXIII force-pushed the TheSpiritXIII/secretless-basic-auth branch from 9305f0b to 9f77219 Compare November 27, 2023 15:57
@TheSpiritXIII TheSpiritXIII merged commit 01145ed into main Nov 27, 2023
9 checks passed
@TheSpiritXIII TheSpiritXIII deleted the TheSpiritXIII/secretless-basic-auth branch November 27, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants