Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Remove default image prefix in skaffold.yaml #71

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Jan 24, 2022

The goal of this PR is to improve the usability of examples for Skaffold users. Removing the us-docker.pkg.dev/anthos-dpe-abm-edge-pos/abm-edge-pos-images/ image prefix will allow to run examples with just the --default-repo option and without having to modify the skaffold.yaml.

Took example from this: GoogleContainerTools/skaffold#3368

@mathieu-benoit mathieu-benoit requested a review from a team as a code owner January 24, 2022 20:02
@mathieu-benoit mathieu-benoit changed the title Update skaffold.yaml cleanup: Remove default image prefix in skaffold.yaml Jan 24, 2022
@Shabirmean Shabirmean merged commit a5d6a11 into main Jan 24, 2022
@Shabirmean Shabirmean deleted the mathieu-benoit/base-image-skaffold branch January 24, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants