fixes

storagetransfer/src/manifest_request.php

@@ -57,13 +57,13 @@ function manifest_request($projectId, $sourceAgentPoolName, $rootDirectory, $sin
     ]);
 
     $client = new StorageTransferServiceClient();
-    $request = (new CreateTransferJobRequest())
+    $createRequest = (new CreateTransferJobRequest())
         ->setTransferJob($transferJob);
-    $response = $client->createTransferJob($request);
-    $request2 = (new RunTransferJobRequest())
+    $response = $client->createTransferJob($createRequest);
+    $runRequest = (new RunTransferJobRequest())
         ->setJobName($response->getName())
         ->setProjectId($projectId);
-    $client->runTransferJob($request2);
+    $client->runTransferJob($runRequest);
 
     printf('Created and ran transfer job from %s to %s using manifest %s with name %s ' . PHP_EOL, $rootDirectory, $sinkGcsBucketName, $manifestLocation, $response->getName());
 }

storagetransfer/src/nearline_request.php

@@ -85,13 +85,13 @@ function nearline_request($projectId, $description, $sourceGcsBucketName, $sinkG
     ]);
 
     $client = new StorageTransferServiceClient();
-    $request = (new CreateTransferJobRequest())
+    $createRequest = (new CreateTransferJobRequest())
         ->setTransferJob($transferJob);
-    $response = $client->createTransferJob($request);
-    $request2 = (new RunTransferJobRequest())
+    $response = $client->createTransferJob($createRequest);
+    $runRequest = (new RunTransferJobRequest())
         ->setJobName($response->getName())
         ->setProjectId($projectId);
-    $client->runTransferJob($request2);
+    $client->runTransferJob($runRequest);
 
     printf('Created and ran transfer job : %s' . PHP_EOL, $response->getName());
 }

storagetransfer/src/posix_request.php

@@ -35,7 +35,6 @@
  * @param string $sourceAgentPoolName The agent pool associated with the POSIX data source.
  * @param string $rootDirectory The root directory path on the source filesystem.
  * @param string $sinkGcsBucketName The name of the GCS bucket to transfer objects to.
- * @param string $manifestLocation Transfer manifest location. Must be a `gs:` URL.
  */
 function posix_request($projectId, $sourceAgentPoolName, $rootDirectory, $sinkGcsBucketName)
 {
@@ -54,13 +53,13 @@ function posix_request($projectId, $sourceAgentPoolName, $rootDirectory, $sinkGc
     ]);
 
     $client = new StorageTransferServiceClient();
-    $request = (new CreateTransferJobRequest())
+    $createRequest = (new CreateTransferJobRequest())
         ->setTransferJob($transferJob);
-    $response = $client->createTransferJob($request);
-    $request2 = (new RunTransferJobRequest())
+    $response = $client->createTransferJob($createRequest);
+    $runRequest = (new RunTransferJobRequest())
         ->setJobName($response->getName())
         ->setProjectId($projectId);
-    $client->runTransferJob($request2);
+    $client->runTransferJob($runRequest);
 
     printf('Created and ran transfer job from %s to %s with name %s ' . PHP_EOL, $rootDirectory, $sinkGcsBucketName, $response->getName());
 }

storagetransfer/src/quickstart.php

@@ -48,13 +48,13 @@ function quickstart($projectId, $sourceGcsBucketName, $sinkGcsBucketName)
     ]);
 
     $client = new StorageTransferServiceClient();
-    $request = (new CreateTransferJobRequest())
+    $createRequest = (new CreateTransferJobRequest())
         ->setTransferJob($transferJob);
-    $response = $client->createTransferJob($request);
-    $request2 = (new RunTransferJobRequest())
+    $response = $client->createTransferJob($createRequest);
+    $runRequest = (new RunTransferJobRequest())
         ->setJobName($response->getName())
         ->setProjectId($projectId);
-    $client->runTransferJob($request2);
+    $client->runTransferJob($runRequest);
 
     printf('Created and ran transfer job from %s to %s with name %s ' . PHP_EOL, $sourceGcsBucketName, $sinkGcsBucketName, $response->getName());
 }

storagetransfer/test/StorageTransferTest.php

@@ -32,13 +32,15 @@ class StorageTransferTest extends TestCase
     use TestTrait;
 
     private static $sts;
+    private static $root;
     private static $storage;
     private static $sourceBucket;
     private static $sinkBucket;
     private static $sourceAgentPoolName;
 
     public static function setUpBeforeClass(): void
     {
+        self::$root = sys_get_temp_dir();
         self::checkProjectEnvVars();
         self::$storage = new StorageClient();
         self::$sts = new StorageTransferServiceClient();
@@ -110,7 +112,7 @@ public function testManifestRequest()
     {
         try {
             $manifestName = 'manifest.csv';
-            $rootDirectory = sys_get_temp_dir() . '/sts-manifest-request-test';
+            $rootDirectory = self::$root . '/sts-manifest-request-test';
             if (!is_dir($rootDirectory)) {
                 mkdir($rootDirectory, 0700, true);
             }
@@ -153,7 +155,7 @@ public function testManifestRequest()
     public function testPosixRequest()
     {
         try {
-            $rootDirectory = sys_get_temp_dir() . '/sts-manifest-request-test';
+            $rootDirectory = self::$root . '/sts-manifest-request-test';
             if (!is_dir($rootDirectory)) {
                 mkdir($rootDirectory, 0700, true);
             }