fix: hint for large copy operations missed 'spanner.' namespace #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hint that was included in the error message that is returned for too large copy operations did not include the 'spanner.' namespace prefix. This would break copy-pasting the hint from the error message to a command console. Fixes b/240604839
Codecov Report
@@ Coverage Diff @@
## postgresql-dialect #304 +/- ##
========================================================
- Coverage 83.04% 82.99% -0.05%
+ Complexity 1338 1337 -1
========================================================
Files 109 109
Lines 4617 4617
Branches 574 574
========================================================
- Hits 3834 3832 -2
- Misses 596 597 +1
- Partials 187 188 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hint that was included in the error message that is returned for too
large copy operations did not include the 'spanner.' namespace prefix.
This would break copy-pasting the hint from the error message to a
command console.
Fixes b/240604839